Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Expose TC_CallCountThreshold and TC_CallCountingDelayMs as runtime knobs #90761

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[release/8.0] Expose TC_CallCountThreshold and TC_CallCountingDelayMs as runtime knobs #90761

merged 1 commit into from
Aug 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 17, 2023 •
edited by EgorBo
Loading

Backport of #90724 to release/8.0

/cc @EgorBo

Customer Impact

We have two groups of low-level configuration knobs:

  1. Only available via env vars (e.g. $env:DOTNET_Foo=1)
  2. Available via env vars and runtime.json + msbuild properties

This PR promotes these two knobs from 1) to 2) because:

  1. We're shipping PGO this relese and it may potentially impact startup time and these settings being promoted make it easier to play with them to mitigate potential startup time regressions
  2. An Internal customer requested these to be available in runtime.config

Testing

Tested locally

Risk

No risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

jeffschwMSFT
jeffschwMSFT approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and then this is ready to merge

@EgorBo
Copy link
Member

EgorBo commented Aug 17, 2023

PTAL @mangod9

@EgorBo EgorBo requested a review from mangod9 August 17, 2023 18:26
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 17, 2023
@carlossanlop
Copy link
Member

Failure is known: #90593

Ready to merge.

@carlossanlop carlossanlop merged commit 38a1170 into release/8.0 Aug 17, 2023
106 of 114 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90724-to-release/8.0 branch August 17, 2023 21:33
@build-analysis build-analysis bot mentioned this pull request Aug 17, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mangod9 mangod9 mangod9 approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EgorBo @carlossanlop @jeffschwMSFT @mangod9